Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made the description below 150 characters #5507

Merged
merged 4 commits into from
Oct 18, 2024
Merged

made the description below 150 characters #5507

merged 4 commits into from
Oct 18, 2024

Conversation

ozearkhan
Copy link
Contributor

Description

Edited the exceptions concept entry under C++ in content/cpp/concepts/exceptions/exceptions.md. The changes include:

  • Shortening the description to be less than 160 characters.
  • Fixing typos in the entry for clarity and correctness.

Issue Solved

Closes #5484

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@cigar-galaxy82 cigar-galaxy82 self-assigned this Oct 16, 2024
@cigar-galaxy82 cigar-galaxy82 added enhancement New feature or request hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest status: under review Issue or PR is currently being reviewed c++ C++ entries status: review 1️⃣ completed status: ready for next review labels Oct 17, 2024
@cigar-galaxy82
Copy link
Contributor

Hi @ozearkhan thank you for contributing to Codecademy docs, the entry looks good.

@mamtawardhani mamtawardhani self-assigned this Oct 17, 2024
@mamtawardhani
Update exceptions.md
ff21730 
minor changes
mamtawardhani
mamtawardhani approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing @ozearkhan 😄

The entry is ready to be merged! 🚀

@mamtawardhani mamtawardhani added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Oct 18, 2024
@mamtawardhani mamtawardhani merged commit 4547532 into Codecademy:main Oct 18, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @ozearkhan
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/cpp/exceptions

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamtawardhani mamtawardhani mamtawardhani approved these changes

@cigar-galaxy82 cigar-galaxy82 cigar-galaxy82 approved these changes

Assignees

@mamtawardhani mamtawardhani

@cigar-galaxy82 cigar-galaxy82

Labels
c++ C++ entries enhancement New feature or request hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Edit] C++ exceptions
3 participants
@ozearkhan @cigar-galaxy82 @mamtawardhani